Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flatMap associativity test for Signal #154

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

armanbilge
Copy link
Owner

Also related to #101.

Really sad about these failures 😕 they are going to need a proper investigation I guess.

Copy link
Collaborator

@2chilled 2chilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but why isn't that reproducible locally? My setup is not that different from CI..

@armanbilge
Copy link
Owner Author

I don't know 😕 which is why it needs a real investigation.

The tests rely on some time-mocking capabilities of Cats Effect test runtime. So maybe there is some issue there, that prevent reproduction even with a hard-coded seed.

It's also really strange that this one started failing, after I disabled the other test. Until now I had never seen it fail before. It feels like there is some strange global state or something.

@armanbilge armanbilge merged commit 4e4d803 into main Jan 21, 2023
@armanbilge armanbilge deleted the pr/disable-flatMap-associativity branch January 21, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants